On Tue, Feb 18, 2014 at 02:55:52PM +0000, Lee Jones wrote:
> diff --git a/drivers/mtd/devices/st_spi_fsm.c 
> b/drivers/mtd/devices/st_spi_fsm.c
> index fe538bb..e4815fe 100644
> --- a/drivers/mtd/devices/st_spi_fsm.c
> +++ b/drivers/mtd/devices/st_spi_fsm.c
> @@ -942,6 +945,100 @@ static int stfsm_n25q_config(struct stfsm *fsm)
[...]
> +static int stfsm_mtd_read(struct mtd_info *mtd, loff_t from, size_t len,
> +                       size_t *retlen, u_char *buf)
> +{
> +     struct stfsm *fsm = dev_get_drvdata(mtd->dev.parent);
> +     uint32_t bytes;
> +
> +     dev_dbg(fsm->dev, "%s from 0x%08x, len %zd\n",
> +             __func__, (u32)from, len);
> +
> +     mutex_lock(&fsm->lock);
> +
> +     while (len > 0) {
> +             bytes = min_t(size_t, len, FLASH_PAGESIZE);
> +
> +             stfsm_read(fsm, buf, bytes, from);
> +
> +             buf += bytes;
> +             from += bytes;
> +             len -= bytes;
> +
> +             if (retlen)

Same as with your _write implementation; you can assume that retlen is
always non-NULL.

> +                     *retlen += bytes;
> +     }
> +
> +     mutex_unlock(&fsm->lock);
> +
> +     return 0;
> +}
> +
>  static void stfsm_read_jedec(struct stfsm *fsm, uint8_t *const jedec)
>  {
>       const struct stfsm_seq *seq = &stfsm_seq_read_jedec;

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to