On 02/25/2014 12:34 PM, Daniel Borkmann wrote: > On 02/25/2014 09:26 PM, H. Peter Anvin wrote: >> On 02/21/2014 02:33 AM, Jan Beulich wrote: >>> ... to match its two callers (i.e. the alternative would have been to >>> swap the arguments at the call sites). >>> >>> Signed-off-by: Jan Beulich <jbeul...@suse.com> >>> Cc: Francesco Fusco <ffu...@redhat.com> >>> Cc: Daniel Borkmann <dbork...@redhat.com> >>> Cc: Thomas Graf <tg...@redhat.com> >>> Cc: David S. Miller <da...@davemloft.net> >>> --- >>> arch/x86/lib/hash.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> Jan, do you want to do an updated version of this patch? Daniel, I >> presume you are going to push this patch? > > Good point. I'm fine if this is going to be picked up > by x86 maintainers. Feel free to add my ... > > Acked-by: Daniel Borkmann <dbork...@redhat.com> > > ... if you want to do an updated version that also > includes our recent findings/discussion, Jan. >
Well, I don't want to change the names of the arguments in the inline function unless we also change the their functions and actually reverse the order of the operands as used. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/