On Mon, Feb 24, 2014 at 03:52:24PM +0000, Austin, Brian wrote: > > > > >> + /* Disable auto-mute */ > >> + regmap_update_bits(cs42888->regmap, CS42888_TXCTL, > >> + CS42888_TXCTL_AMUTE | CS42888_TXCTL_DAC_SZC_MASK, > >> + CS42888_TXCTL_DAC_SZC_SR); > > > > Does this interfere with the manual mute controls or is it a separate > > thing? If it plays nicely with the manual controls it's probably better > > to leave it enabled since it improves performance in some benchmarks > > (that's why hardware tends to have the feature). > > Auto-Mute should be enabled by default. > > > > >> + if (!IS_ERR(cs42888->clk)) > >> + clk_disable_unprepare(cs42888->clk); > > > > Does the device work without MCLK? > Yes, MCLK is required. If you can’t get the clock you should error out. > >
Will refine it as you suggest. Thank you for the comments. Nicolin Chen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
