Re: [PATCH] ASoC: cs42888: Add codec driver support

[Austin, Brian]

> 
>> +    /* Disable auto-mute */
>> +    regmap_update_bits(cs42888->regmap, CS42888_TXCTL,
>> +                       CS42888_TXCTL_AMUTE | CS42888_TXCTL_DAC_SZC_MASK,
>> +                       CS42888_TXCTL_DAC_SZC_SR);
> 
> Does this interfere with the manual mute controls or is it a separate
> thing?  If it plays nicely with the manual controls it's probably better
> to leave it enabled since it improves performance in some benchmarks
> (that's why hardware tends to have the feature).

Auto-Mute should be enabled by default.

> 
>> +    if (!IS_ERR(cs42888->clk))
>> +            clk_disable_unprepare(cs42888->clk);
> 
> Does the device work without MCLK?
Yes, MCLK is required. If you can’t get the clock you should error out.

signature.asc
Description: Message signed with OpenPGP using GPGMail