On 2014-02-16 08:41, Chase Southwood wrote:
This patch for hwdrv_apci035.c changes a printk() call to a dev_err call since this is generally preferred.Signed-off-by: Chase Southwood <chase.southw...@yahoo.com> --- drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c index 90d5801..f02b714 100644 --- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c +++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c @@ -227,7 +227,7 @@ static int i_APCI035_ConfigTimerWatchdog(struct comedi_device *dev, ui_Command = ui_Command & 0xFFF819E2UL; } else { - printk("\n The parameter for Timer/watchdog selection is in error\n"); + dev_err(dev->class_dev, "\n The parameter for Timer/watchdog selection is in error\n"); return -EINVAL; } }
It'd be great if you could get rid of the initial "\n " in the error string too.
-- -=( Ian Abbott @ MEV Ltd. E-mail: <abbo...@mev.co.uk> )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
