On Sat, Feb 15, 2014 at 11:57:02PM +0530, Jassi Brar wrote: > From: Suman Anna <s-a...@ti.com> > > This is needed for extracting the omap_mbox. The OMAP mailbox > code has a need for exporting some pre-existing API to not > break the current clients. > > Signed-off-by: Suman Anna <s-a...@ti.com> > ---
You don't agree with this patch and sign off on it? > drivers/mailbox/mailbox.c | 62 +----------------------------- > drivers/mailbox/mailbox_internal.h | 77 > ++++++++++++++++++++++++++++++++++++++ > 2 files changed, 78 insertions(+), 61 deletions(-) > create mode 100644 drivers/mailbox/mailbox_internal.h Why not just do this in the first patch(s)? Why wait for later in the series to "fix" things up? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/