On Thu, Feb 13, 2014 at 09:14:11AM +0000, Laszlo Papp wrote:
> On Thu, Feb 13, 2014 at 8:23 AM, Lee Jones <lee.jo...@linaro.org> wrote:
> > Laszlo,
> >
> >> > +const struct regmap_config max665x_regmap_config = {
> >> > + .reg_bits = 5,
> >> > +};> >> This would normally be static too, and I'd *really* expect to see a > >> val_bits set here. I'm a bit surprised this works without one. > > Mark (privately) mentioned to me that this patch can't possibly work > > given the current Regmap configuration. > Strange because I have tested the change, although not for days and > weeks. What exactly cannot possible work? The fact that it's using 5 bit registers should cause it to be rejected when trying to initialise as the regmap code doesn't support 5 bit registers, and I'd not expect us to have selected sensible value formatting code either.
signature.asc
Description: Digital signature
