On 02/11/2014 09:20 PM, Guenter Roeck wrote: > On Tue, Feb 11, 2014 at 07:55:50AM +0100, Michal Simek wrote: >> Use of_property_read_u32 functions to clean probe function. >> >> Signed-off-by: Michal Simek <michal.si...@xilinx.com> >> --- >> > [ ... ] > >> + >> + if (enable_once) >> watchdog_set_nowayout(xilinx_wdt_wdd, true); >> - } > > watchdog_set_nowayout(xilinx_wdt_wdd, enable_once); > > would probably do as well (the function checks the flag as well). > > Nitpick, so > > Reviewed-by: Guenter Roeck <li...@roeck-us.net>
I will change it and send v3. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
signature.asc
Description: OpenPGP digital signature
