On 02/04, Steven Rostedt wrote:
>
> Now to fix this we need to save the filename before calling
> search_binary_handler(). But we don't want to save it if we are not
> tracing. Why slow everyone else down?
Yes, but it would be much simpler to dup filename unconditionally.
Note also that in this case we can kill linux_binprm->tcomm[] and
simplify filename_to_taskname().
> This works, but is rather ugly.
Yes ;)
> Looking for any other suggestions here.
Perhaps we can change flush_old_exec() to do
if (!current->mm) {
bprm->filename = kstrdup(bprm->filename);
if (bprm->filename)
bprm->filename_was_dupped = true; // for free_bprm()
else
bprm->filename = "//enomem";
}
This won't penalize the normal exec, and this should fix the problem
afaics.
Perhaps, instead of "//enomem" flush_old_exec() should simply fail,
in this case we can kill bprm->tcomm[] too.
Oleg.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
