On 01/17/2014 04:54 AM, Peter Zijlstra wrote: > On Fri, Jan 17, 2014 at 01:17:36AM -0500, r...@redhat.com wrote: >> + /* >> + * Normalize the faults_from, so all tasks in a group >> + * count according to CPU use, instead of by the raw >> + * number of faults. This prevents the situation where >> + * the garbage collector totally dominates the stats, >> + * and the access patterns of the worker threads are >> + * ignored. >> + */ > > Instead of focusing on the one example (GC) here, I would suggest > saying something along the lines of: Tasks with little runtime have > little over-all impact on throughput and thus their faults are less > important.
Thanks for the review, I have updated the comment accordingly. Does anybody else have comments on this series, or should I start begging for Acked-by: and Reviewed-by: lines? :) -- All rights reversed -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
