On 01/14, Oleg Nesterov wrote: > > > + get_seccomp_filter(caller); > > + /* > > + * Drop the task reference to the shared ancestor since > > + * current's path will hold a reference. (This also > > + * allows a put before the assignment.) > > + */ > > + put_seccomp_filter(thread); > > + thread->seccomp.filter = caller->seccomp.filter; > > As I said, I do not understand this patch yet, but this looks suspicious. > > Why we can't race with this thread doing clone(CLONE_THREAD) ? We do > not the the new thread yet, but its ->seccomp can be already copied > by copy_process(), no?
And it seems that this can obviously race with seccomp_attach_filter() called by this "thread". Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
