On Mon, Jan 13, 2014 at 04:49:06PM +0100, Oleg Nesterov wrote:
> The slow path in __fget_light() can use __fget() to avoid the
> code duplication. Saves 232 bytes.
>
> Signed-off-by: Oleg Nesterov <o...@redhat.com>
Reviewed-by: Paul E. McKenney <paul...@linux.vnet.ibm.com>
> ---
> fs/file.c | 14 +++-----------
> 1 files changed, 3 insertions(+), 11 deletions(-)
>
> diff --git a/fs/file.c b/fs/file.c
> index 50c1208..771578b 100644
> --- a/fs/file.c
> +++ b/fs/file.c
> @@ -694,17 +694,9 @@ struct file *__fget_light(unsigned int fd, fmode_t mask,
> int *fput_needed)
> if (file && (file->f_mode & mask))
> file = NULL;
> } else {
> - rcu_read_lock();
> - file = fcheck_files(files, fd);
> - if (file) {
> - if (!(file->f_mode & mask) &&
> - atomic_long_inc_not_zero(&file->f_count))
> - *fput_needed = 1;
> - else
> - /* Didn't get the reference, someone's freed */
> - file = NULL;
> - }
> - rcu_read_unlock();
> + file = __fget(fd, mask);
> + if (file)
> + *fput_needed = 1;
> }
>
> return file;
> --
> 1.5.5.1
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
