On Mon, Jan 13, 2014 at 04:12:45AM +0000, Caizhiyong wrote: > > -----Original Message----- > > From: Brian Norris [mailto:computersforpe...@gmail.com] > > Sent: Sunday, January 12, 2014 4:10 AM > > > > On Thu, Dec 26, 2013 at 10:19:39AM +0800, Huang Shijie wrote: > > > On Thu, Dec 26, 2013 at 01:51:58AM +0000, Caizhiyong wrote: > > > > From: Cai Zhiyong <caizhiy...@huawei.com> > > > > Date: Wed, 25 Dec 2013 21:19:21 +0800 > > > > Subject: [PATCH] mtd: nand: assign mtd->name in find_full_id_nand > > > > > > > > This patch assigned the type->name to mtd->name when mtd->name is > > > > NULL in function "find_full_id_nand". > > > > mtd->name is NULL may cause some problem. > > > > > > > > Signed-off-by: Cai Zhiyong <caizhiy...@huawei.com> > > > Acked-by: Huang Shijie <b32...@freescale.com> > > > > Thanks, the patch looks good. Pushed to l2-mtd.git. > > > > Wouldn't this trigger an exception when reading > > /sys/class/mtd/mtdX/name? If so, should this be marked for stable? > > View the source code, if mtd->name is NULL, cat "/sys/class/mtd/mtdX/name" > will get string "(null)". > > static ssize_t mtd_name_show(struct device *dev, struct device_attribute > *attr, char *buf) > { > struct mtd_info *mtd = dev_get_drvdata(dev); > > return snprintf(buf, PAGE_SIZE, "%s\n", mtd->name); > }
Thanks, I forgot that the kernel's printf-like functions handle NULL pointers gracefully. In that case, this probably doesn't need to be in -stable. Brian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
