On 01/07/2014 06:57 PM, Muthu Kumar wrote: > Jens, > In bio_endio if bio doesn't have bi_end_io (should be an error case), > we set bio to NULL and continue silently without freeing the bio. It > would be good to have a WARN and free the bio to avoid memory leak. > > If you agree, here is the patch.
I don't remember off the top of my head if there are valid uses cases of it. But leaking it would definitely be problematic. So I think it's a good idea to queue it up, then we'll see if it triggers anything. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/