On Mon, 6 Jan 2014, Konrad Rzeszutek Wilk wrote: > On Fri, Jan 03, 2014 at 01:35:52PM +0000, Stefano Stabellini wrote: > > On Tue, 31 Dec 2013, Konrad Rzeszutek Wilk wrote: > > > There is no need for that so lets use ratelimiting. > > > Also add some extra information to be helpful. > > > > > > CC: Stefano Stabellini <stefano.stabell...@eu.citrix.com> > > > Signed-off-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> > > > > lib/swiotlb.c: In function 'swiotlb_tbl_map_single': > > lib/swiotlb.c:509:3: warning: format '%ld' expects argument of type 'long > > int', but argument 3 has type 'size_t' [-Wformat=] > > > > How about this: > > >From c83a2ab5d5fbc502b4165262a2983c2ad646f061 Mon Sep 17 00:00:00 2001 > From: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> > Date: Mon, 16 Dec 2013 14:05:01 -0500 > Subject: [PATCH] swiotlb: Don't DoS us with 'swiotlb buffer is full' (v2) > > There is no need for that so lets use ratelimiting. > Also add some extra information to be helpful. > > CC: Stefano Stabellini <stefano.stabell...@eu.citrix.com> > [v2: s/ld/zs on the printk] > Signed-off-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com>
Acked-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> > lib/swiotlb.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/swiotlb.c b/lib/swiotlb.c > index e4399fa..4634ac9 100644 > --- a/lib/swiotlb.c > +++ b/lib/swiotlb.c > @@ -505,7 +505,8 @@ phys_addr_t swiotlb_tbl_map_single(struct device *hwdev, > > not_found: > spin_unlock_irqrestore(&io_tlb_lock, flags); > - dev_warn(hwdev, "swiotlb buffer is full\n"); > + if (printk_ratelimit()) > + dev_warn(hwdev, "swiotlb buffer is full (sz: %zd bytes)\n", > size); > return SWIOTLB_MAP_ERROR; > found: > spin_unlock_irqrestore(&io_tlb_lock, flags); > -- > 1.8.3.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
