Hi! > Review of the superio subsystem sneaked in through bk-i2c.patch: > > > diff -Nru a/drivers/superio/Kconfig b/drivers/superio/Kconfig > --- /dev/null Wed Dec 31 16:00:00 196900 > +++ b/drivers/superio/Kconfig 2005-01-23 22:34:15 -08:00 > @@ -0,0 +1,56 @@ > +menu "SuperIO subsystem support" > + > +config SC_SUPERIO > + tristate "SuperIO subsystem support" > + depends on CONNECTOR > + help > + SuperIO subsystem support. > + > + This support is also available as a module. If so, the module > + will be called superio.ko. > > This doesn't mention what "SuperIO" is at all. Also please skip the .ko > postfix for the module name as the intree Kconfigs do. The boilerplate has > changed to: > > To compile this driver as a module, choose M here: the > module will be called <foo>.
Could we kill this boilerplate? Just explain modules in CONFIG_MODULE or something like that. Or making module name mandatory parameter for tristates, or something like that... Pavel -- People were complaining that M$ turns users into beta-testers... ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/