On Mon, Jan 24, 2005 at 10:31:53PM +0100, Brice Goglin wrote:
> Dave Jones a écrit :
> >Here's the most obvious bug fixed. There still seems to be
> >something wrong however. It only successfully boots 50% of the
> >time for me, (it reboots when starting X otherwise), and when
> >it does boot, I get a flood of ...
> >Warning: kfree_skb on hard IRQ cf7b5800
> >Warning: kfree_skb on hard IRQ cf7b5800
> >Warning: kfree_skb on hard IRQ cf7b5800
> >
> >I think there may be some stupid memory corruptor bug in there still.
>
> Thanks, your patch makes X work again with DRI.
> Actually, it successfully booted 100% of the time here.
> I tried 6 or 7 times without seeing any problem like yours.
> Let me know if you want me to try something special.
It's quite remarkable that it works at all.
This is needed too on top of -mm1.
Dave
# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
# 2005/01/25 14:27:39-05:00 [EMAIL PROTECTED]
# [AGPGART] Silly thinko in reserve bit masking.
#
# Stupid inversion meant we passed '0' to userspace, and madness
# ensued resulting in very funky visuals.
#
# Signed-off-by: Dave Jones <[EMAIL PROTECTED]>
#
diff -Nru a/drivers/char/agp/generic.c b/drivers/char/agp/generic.c
--- a/drivers/char/agp/generic.c 2005-01-25 14:34:24 -05:00
+++ b/drivers/char/agp/generic.c 2005-01-25 14:34:24 -05:00
@@ -324,9 +324,9 @@
info->chipset = agp_bridge->type;
info->device = agp_bridge->dev;
if (check_bridge_mode(agp_bridge->dev))
- info->mode = agp_bridge->mode & AGP3_RESERVED_MASK;
+ info->mode = agp_bridge->mode & ~AGP3_RESERVED_MASK;
else
- info->mode = agp_bridge->mode & AGP2_RESERVED_MASK;
+ info->mode = agp_bridge->mode & ~AGP2_RESERVED_MASK;
info->aper_base = agp_bridge->gart_bus_addr;
info->aper_size = agp_return_size();
info->max_memory = agp_bridge->max_memory_agp;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
