> Hi Ariel. > > I wrote a little checkpatch script to look for missing > switch/case breaks. > > http://www.kernelhub.org/?msg=379933&p=2 > > There are _many_ instances of case blocks in sriov.c > that could be missing breaks as they use fall-throughs. > > It would be good if these are actually intended to be > fall-throughs to add a /* fall-through */ comment between > each case block. > > For instance: > > static void bnx2x_vfop_qctor(struct bnx2x *bp, struct bnx2x_virtf *vf) > { > [...] > switch (state) { > case BNX2X_VFOP_QCTOR_INIT: > > /* has this queue already been opened? */ > if (bnx2x_get_q_logical_state(bp, q_params->q_obj) == > BNX2X_Q_LOGICAL_STATE_ACTIVE) { > DP(BNX2X_MSG_IOV, > "Entered qctor but queue was already up. Aborting > gracefully\n"); > goto op_done; > } > > /* next state */ > vfop->state = BNX2X_VFOP_QCTOR_SETUP; > > q_params->cmd = BNX2X_Q_CMD_INIT; > vfop->rc = bnx2x_queue_state_change(bp, q_params); > > bnx2x_vfop_finalize(vf, vfop->rc, VFOP_CONT);
Hi Joe, The `vfop' part of the code contains a lot of usage of the `bnx2x_vfop_finalize()', which either goto or return at the end of almost every case. "Normal" analysis tools/scripts fail to recognize them as valid case breaks. Adding `fallthrough' comments would make little sense, as this is not the real behavior; Perhaps we need some alternative comment? (something in the line of `macro case break') Cheers, Yuval -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
