On Wed, Dec 11, 2013 at 08:50:01AM +0800, Wanpeng Li wrote: > Drop unnecessary total_faults variable in function task_weight to unify > task_weight and group_weight. > > Reviewed-by: Naoya Horiguchi <n-horigu...@ah.jp.nec.com> > Signed-off-by: Wanpeng Li <liw...@linux.vnet.ibm.com>
Nak. task_weight is called for tasks other than current. If p handles a fault in parallel then it can drop to 0 between when it's checked and used to divide resulting in an oops. -- Mel Gorman SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/