I was looking into the lockdep splat reported by Sasha yesterday and came across a few issues (unfortunately not related) in the timekeeping code.
The first two are issues related to not updating the shadow timekeeper after making changes to the timekeeper structure. This means those updates could be lost the next time we do update_wall_time(), since update_wall_time assumes the shadow_timekeeper is current as well. The last change is an obvious issue that I should have caught in review, but where we handle notifying the pvclock code if time was set, there's one case in logarithmic_accumulation where we just don't pass that flag down. Of the three patches, the first is really the most critical. I'm thinking of pushing that one into 3.13, and immediately back to 3.12-stable and 3.10-stable. Then leaving the last two for 3.14, and pushing back to 3.13/10-stable once those changes are merged. I'm still running some tests on these, but I wanted to send them out as RFCs to get some extra review and thoughts before I send them out for real. thanks -john Cc: Thomas Gleixner <t...@linutronix.de> Cc: Prarit Bhargava <pra...@redhat.com> Cc: Richard Cochran <richardcoch...@gmail.com> Cc: Ingo Molnar <mi...@kernel.org> Cc: David Vrabel <david.vra...@citrix.com> John Stultz (3): timekeeping: Fix lost updates to tai adjustment timekeeping: Fix missing timekeeping_update in suspend path timekeeping: Fix potential lost pv notification of time change kernel/time/timekeeping.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) -- 1.8.3.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
