On Tue, 2013-12-03 at 11:01 +0000, David Vrabel wrote: > On 03/12/13 10:57, Roger Pau Monne wrote: > > Using __packed__ on the public interface is not correct, this > > structures should be compiled using the native ABI, and __packed__ > > should only be used in the backend counterpart of those structures > > (which needs to handle different ABIs). > > > > This was even worse in the ARM case, where the Linux kernel was > > incorrectly using the X86_32 protocol ABI. This patch fixes it, but > > also breaks compatibility, so an ARM DomU kernel compiled with > > this patch will fail to communicate with PV disk devices unless the > > Dom0 also has this patch. > > This ABI change needs to be justified. Why do you think it is > acceptable to break existing Linux guests? Because I don't think it is.
As I explained in my reply those guests are buggy. Ian. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/