> -----Original Message----- > From: xen-devel-boun...@lists.xen.org [mailto:xen-devel- > boun...@lists.xen.org] On Behalf Of David Vrabel > Sent: 03 December 2013 11:01 > To: Roger Pau Monne > Cc: Stefano Stabellini; Julien Grall; linux-kernel@vger.kernel.org; xen- > de...@lists.xenproject.org; Boris Ostrovsky > Subject: Re: [Xen-devel] [PATCH RFC] xen-block: correctly define structures > in public headers > > On 03/12/13 10:57, Roger Pau Monne wrote: > > Using __packed__ on the public interface is not correct, this > > structures should be compiled using the native ABI, and __packed__ > > should only be used in the backend counterpart of those structures > > (which needs to handle different ABIs). > > > > This was even worse in the ARM case, where the Linux kernel was > > incorrectly using the X86_32 protocol ABI. This patch fixes it, but > > also breaks compatibility, so an ARM DomU kernel compiled with > > this patch will fail to communicate with PV disk devices unless the > > Dom0 also has this patch. > > This ABI change needs to be justified. Why do you think it is > acceptable to break existing Linux guests? Because I don't think it is. >
Even if they are lying about their ABI? Paul > David > > _______________________________________________ > Xen-devel mailing list > xen-de...@lists.xen.org > http://lists.xen.org/xen-devel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
