On Sun, 2013-11-17 at 15:51 -0300, Geyslan G. Bem wrote: > This patch fix memory leakage in cases 'ISCSI_NET_PARAM_VLAN_ID' and > 'ISCSI_NET_PARAM_VLAN_PRIORITY' and refactors code 'going out' when > necessary.
You pointlessly renamed a variable, which makes the diff hard to read. Please don't do that. You missed the fact that the passed in pointer is unmodified if mgmt_get_if_info() returns non zero, so the kfree frees junk and would oops. There's no need for a goto; len = -EINVAL; does everything that's needed. James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
