On Tue, 22 Oct 2013 14:56:50 +0400, Stanislav Fomichev wrote: > Add titles to figures so we can run SVG interactively in Firefox > and check event details in the tooltips. > This also aids exploring SVG with Inkscape because when user clicks on > one part of logical figure, all parts are selected. > It's also possible to read titles with Inkscape in the object details.
I have a trivial nitpick below, other than that Acked-by: Namhyung Kim <namhy...@kernel.org> > > Signed-off-by: Stanislav Fomichev <stfomic...@yandex-team.ru> > --- > tools/perf/builtin-timechart.c | 4 ++-- > tools/perf/util/svghelper.c | 54 > +++++++++++++++++++++++++++++++++++++++++- > tools/perf/util/svghelper.h | 3 ++- > 3 files changed, 57 insertions(+), 4 deletions(-) > > diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-timechart.c > index c7b30a8c7f3b..4d2ac96b75b1 100644 > --- a/tools/perf/builtin-timechart.c > +++ b/tools/perf/builtin-timechart.c > @@ -798,9 +798,9 @@ static void draw_process_bars(void) > if (sample->type == TYPE_RUNNING) > svg_sample(Y, sample->cpu, > sample->start_time, sample->end_time); For consistency, wouldn't it be better renaming svg_sample() to svg_running()? Thanks, Namhyung > if (sample->type == TYPE_BLOCKED) > - svg_box(Y, sample->start_time, > sample->end_time, "blocked"); > + svg_blocked(Y, sample->cpu, > sample->start_time, sample->end_time); > if (sample->type == TYPE_WAITING) > - svg_waiting(Y, sample->start_time, > sample->end_time); > + svg_waiting(Y, sample->cpu, > sample->start_time, sample->end_time); > sample = sample->next; > } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
