On 10/07/2013 06:28 AM, Mel Gorman wrote: > There are three callers of task_numa_fault(): > > - do_huge_pmd_numa_page(): > Accounts against the current node, not the node where the > page resides, unless we migrated, in which case it accounts > against the node we migrated to. > > - do_numa_page(): > Accounts against the current node, not the node where the > page resides, unless we migrated, in which case it accounts > against the node we migrated to. > > - do_pmd_numa_page(): > Accounts not at all when the page isn't migrated, otherwise > accounts against the node we migrated towards. > > This seems wrong to me; all three sites should have the same > sementaics, furthermore we should accounts against where the page > really is, we already know where the task is. > > So modify all three sites to always account; we did after all receive > the fault; and always account to where the page is after migration, > regardless of success. > > They all still differ on when they clear the PTE/PMD; ideally that > would get sorted too. > > Cc: stable <sta...@vger.kernel.org> > Signed-off-by: Peter Zijlstra <pet...@infradead.org> > Signed-off-by: Mel Gorman <mgor...@suse.de>
Reviewed-by: Rik van Riel <r...@redhat.com> -- All rights reversed -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
