On Fri, 04 Oct 2013 11:07:45 -0700 Joe Perches <j...@perches.com> wrote:
> On Fri, 2013-10-04 at 09:36 -0700, Srinivas Pandruvada wrote: > > The Intel Running Average Power Limit(RAPL) technology provides > > platform software with the ability to monitor, control, and get > > notifications on power usage. > [] > > diff --git a/drivers/powercap/Makefile b/drivers/powercap/Makefile > [] > > +/* bitmasks for RAPL MSRs, used by primitive access functions */ > > +#define ENERGY_STATUS_MASK 0xffffffff > > + > > +#define POWER_LIMIT1_MASK 0x7FFF > > +#define POWER_LIMIT1_ENABLE BIT(15) > > +#define POWER_LIMIT1_CLAMP BIT(16) > > + > > +#define POWER_LIMIT2_MASK (0x7FFFULL<<32) > > +#define POWER_LIMIT2_ENABLE BIT_ULL(47) > > +#define POWER_LIMIT2_CLAMP BIT_ULL(48) > > +#define POWER_PACKAGE_LOCK BIT_ULL(63) > > +#define POWER_PP_LOCK BIT(31) > > + > > +#define TIME_WINDOW1_MASK (0x7F<<17) > > +#define TIME_WINDOW2_MASK (0x7FULL<<49) > > > Is there a reason why these masks aren't all ULL? > > are you referring to this line below not being ULL? > > +#define TIME_WINDOW1_MASK (0x7F<<17) if this is the case, I did that because it is not more than 32 bit. Thanks, Jacob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
