On Thursday, September 26, 2013 11:10 AM, Jingoo Han wrote:
>
> Use devm_regulator_register() to make cleanup paths simpler.
>
> Signed-off-by: Jingoo Han <jg1....@samsung.com>
> ---
> drivers/regulator/max8952.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
[.....]
> @@ -321,9 +322,6 @@ static int max8952_pmic_remove(struct i2c_client *client)
> {
> struct max8952_data *max8952 = i2c_get_clientdata(client);
> struct max8952_platform_data *pdata = max8952->pdata;
> - struct regulator_dev *rdev = max8952->rdev;
> -
> - regulator_unregister(rdev);
>
> gpio_free(pdata->gpio_vid0);
> gpio_free(pdata->gpio_vid1);
CC'ed Sachin Kamat,
Freeing the gpios before unregistering the device is not right,
even though it does not make the functional problems.
So, I will remove this patch from v3 patch series.
Best regards,
Jingoo Han
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
