On Thursday, September 26, 2013 3:14 PM, Sachin Kamat wrote: > On 26 September 2013 07:35, Jingoo Han <jg1....@samsung.com> wrote: > > Use devm_regulator_register() to make cleanup paths simpler. > > > struct fixed_voltage_data *drvdata = platform_get_drvdata(pdev); > > > > - regulator_unregister(drvdata->dev); > > kfree(drvdata->desc.supply_name); > > kfree(drvdata->desc.name); > > Sorry, couldn't go through all your patches yesterday. > This one looks a bit scary too as some of the driver data is already > freed before unregistering. >
I looked at regulator_unregister(). I am not sure that this is safe. So, I will remove this patch from next v3 patch series. Thank you for your comment. :-) Best regards, Jingoo Han -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
