ACK, but...
On 09/15, Tetsuo Handa wrote:
>
> @@ -572,6 +572,10 @@ int call_usermodehelper_exec(struct subprocess_info
> *sub_info, int wait)
> int retval = 0;
>
> helper_lock();
> + if (!sub_info->path) {
> + retval = -ENOENT;
> + goto out;
> + }
May I suggest you to send v2?
It looks a bit ugly to check ->path under helper_lock(), just add
if (!sub_info->path)
retval = -ENOENT;
at the start. Otherwise the code looks as if there is a subtle
reason to take the lock before this check.
Perhaps you can also mention that this problems was fixed by
264b83c07a and right after that 7f57cfa4e2 reintroduced it,
because I am stupid.
Oleg.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
