On 30.08.13 17:18:36, Sedat Dilek wrote: > So, I tried to build perf the "official" way: > > $ make -C tools/ perf_install > > Unfortunately, my build breaks like this: > ... > make[2]: Entering directory > `~/src/linux-kernel/linux/tools/lib/traceevent' > make[2]: Leaving directory > `~/src/linux-kernel/linux/tools/lib/traceevent' > LINK perf > gcc: error: ~/src/linux-kernel/linux/tools/lib/lk/liblk.a: No such file or > directory > make[1]: *** [perf] Error 1 > make[1]: Leaving directory `~/src/linux-kernel/linux/tools/perf' > make: *** [perf_install] Error 2 > > After some discussion on IRC with peterz and acme and a closer look at > the targets in "tools/Makefile", I have noticed that the perf_install > target misses liblk to be built beforehand.
There are no build prerequisites on purpose for install targets. Install targets are intended to be run with root permissions. We don't want to create/overwrite files in the build directory as root while running install rules. Thus, you always need to run: $ make -C tools/ perf or similar first. > On the contrary the perf_clean target invokes to clean liblk when perf > is cleaned. > > [ tools/Makefile ] > ... > perf_clean: liblk_clean > $(call descend,$(@:_clean=),clean) > ... > > Fix this by adding liblk target to perf_install target. So no, this is not the proper fix. Before installing you *need* to build. You might want to fix the documenation... -Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
