On Thu, Aug 22, 2013 at 12:38:12PM +0530, Aneesh Kumar K.V wrote: > Joonsoo Kim <iamjoonsoo....@lge.com> writes: > > > Hello, Aneesh. > > > > First of all, thank you for review! > > > > On Wed, Aug 21, 2013 at 02:58:20PM +0530, Aneesh Kumar K.V wrote: > >> Joonsoo Kim <iamjoonsoo....@lge.com> writes: > >> > >> > If we alloc hugepage with avoid_reserve, we don't dequeue reserved one. > >> > So, we should check subpool counter when avoid_reserve. > >> > This patch implement it. > >> > >> Can you explain this better ? ie, if we don't have a reservation in the > >> area chg != 0. So why look at avoid_reserve. > > > > We don't consider avoid_reserve when chg != 0. > > Look at following code. > > > > + if (chg || avoid_reserve) > > + if (hugepage_subpool_get_pages(spool, 1)) > > > > It means that if chg != 0, we skip to check avoid_reserve. > > when whould be avoid_reserve == 1 and chg == 0 ?
In this case, we should do hugepage_subpool_get_pages(), since we don't get a reserved page due to avoid_reserve. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
