Re: [PATCH v2 4/5] PCI: mvebu: add support for reset on GPIO

[Thierry Reding]

On Tue, Aug 13, 2013 at 02:25:23PM +0200, Sebastian Hesselbarth wrote:
[...]
> diff --git a/drivers/pci/host/pci-mvebu.c b/drivers/pci/host/pci-mvebu.c
[...]
> @@ -897,6 +904,30 @@ static int mvebu_pcie_probe(struct platform_device *pdev)
[...]
> +                     u32 reset_udelay = 20000;
[...]
> +                     udelay(reset_udelay);

udelay(20000) is probably not a good idea. You should probably use
something like usleep_range() or msleep() here. Also see:

        Documentation/timers/timers-howto.txt

Thierry

pgpPqa97LdZwe.pgp
Description: PGP signature