On Mon, Aug 05, 2013 at 09:52:28AM +0530, Preeti U Murthy wrote: > On 08/02/2013 04:02 PM, Peter Zijlstra wrote: > > On Fri, Aug 02, 2013 at 02:56:14PM +0530, Preeti U Murthy wrote: > >>>> You need to iterate over all the groups of the sched domain env->sd and > >>>> not just the first group of env->sd like you are doing above. This is to > >>> > >>> I don't think so. > >>> IIRC, env->sd->groups always means local group, > >>> so we don't need to find our group by iterating over all the groups. > >> > >> Take a look at update_sd_lb_stats(). That should clarify this. There is > >> an exclusive > >> local_group check there. > >> > >> sd->groups points to the first group in the list of groups under this sd. > > > > Take a look at: 88b8dac0a > > > Ah ok! Thanks for this pointer. > > Apologies for having overlooked the fact that the sd->groups always > points to the group to which the balance_cpu belongs. And subsequent > dst_cpus for retries of load balancing also belong to the same group as > the balance_cpu. > > This patch thus looks fine to me.
Okay! > > Regards > Preeti U Murthy > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
