Hi Mark, On Fri, Jul 26, 2013 at 11:46 AM, Mark Brown <broo...@kernel.org> wrote: > On Fri, Jul 26, 2013 at 11:25:30AM -0700, Felipe F. Tonello wrote: > >> - snprintf(kctl->id.name, sizeof(kctl->id.name), "%s Jack", name); >> + >> + strlcpy(kctl->id.name, name, sizeof(kctl->id.name)); > > This looks like it'd break existing users unless they are updated to > remove the "Jack" from their calls?
Yes, that's why I appended the " Jack" in snd_jack_new(). > >> * @type: a bitmask of enum snd_jack_type values that can be detected by >> * this jack >> + * @idx: index of this control item >> * @jjack: Used to provide the allocated jack object to the caller. > > "The index of the ALSA control created to represent the jack. Ok. Felipe Tonello -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
