On 26.7.2013 14:20, Frank Haverkamp wrote: > Hi Michael, > > Am Donnerstag, den 25.07.2013, 15:21 +0200 schrieb Michal Marek: >> On 25.7.2013 10:28, Frank Haverkamp wrote: >>> + dev_info(&pci_dev->dev, "GenWQE driver version: %s (build %s) %s%u\n", >>> + DRV_VERS_STRING, __DATE__, GENWQE_DEVNAME, cd->card_idx); >> [...] >>> + len += scnprintf(&buf[len], PAGE_SIZE - len, >>> + "GenWQE driver version: %s (build %s)\n" >>> + " Device Name/Type: %s %s CardIdx: %d\n" >>> + " SLU/APP Config : 0x%016llx/0x%016llx\n" >>> + " Build Date/Type : %u/%x/%u %s\n" >>> + " Base Clock : %u MHz\n" >>> + " Arch/SVN Release: %u/%llx\n" >>> + " Bitstream : %llx\n", >>> + DRV_VERS_STRING, __DATE__, dev_name(&pci_dev->dev), >> >> Please remove the __DATE__ macros, so that the generated object code >> does not literally change with the phase of the moon. >> >> Michal > > Thanks for reviewing. I removed them in my copy. Would that be something > scripts/checkpatch.pl could warn about?
I did submit a patch for checkpatch.pl to do exactly that, but it was not applied. I will resend it, thanks for the reminder. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
