On Thu, Jul 25, 2013 at 4:07 AM, Greg Kroah-Hartman <gre...@linuxfoundation.org> wrote: > On Thu, Jul 25, 2013 at 02:08:19AM +0800, Peng Tao wrote: >> From: Peng Tao <tao.p...@emc.com> >> >> Should be y instead of true. >> >> Reported-by: Paul Bolle <pebo...@tiscali.nl> >> Cc: Andreas Dilger <andreas.dil...@intel.com> >> Signed-off-by: Peng Tao <tao.p...@emc.com> >> --- >> drivers/staging/lustre/lustre/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/staging/lustre/lustre/Kconfig >> b/drivers/staging/lustre/lustre/Kconfig >> index 9ae7fa8..e3b3c74 100644 >> --- a/drivers/staging/lustre/lustre/Kconfig >> +++ b/drivers/staging/lustre/lustre/Kconfig >> @@ -52,4 +52,4 @@ config LUSTRE_DEBUG_EXPENSIVE_CHECK >> config LUSTRE_TRANSLATE_ERRNOS >> bool >> depends on LUSTRE_FS && !X86 >> - default true >> + default y > > Why is the default for this going to be 'y'? That should only be for > things that keep the machine from booting. > > If this is something you always want to do, then why make it an option > at all? > > Given that there is no documentation for what this option is, and why > people should always turn it on, I can't accept this patch, sorry. > I was hoping to use the config option to control over whether the translation code need to be compiled. After checking other Makefiles, I found that I can just use ifeq clause in Makefile to do it. So this config option can be deleted. I will send updated patch.
Thanks, Tao -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
