On 07/23/2013 12:36 AM, Laxman Dewangan wrote:
> Add of_device_id table for Palma GPIO to be enable the
> driver from DT file.
> 
> The driver can be registered from DT file as:
>       palmas: tps65913@58 {
>               :::::::::::
>               palmas_gpio: palmas_gpio {
>                       compatible = "ti,palmas-gpio";
>                       gpio-controller;
>                       #gpio-cells = <2>;
>               };
>       };

The binding at least,
Acked-by: Stephen Warren <swar...@nvidia.com>

> diff --git a/drivers/gpio/gpio-palmas.c b/drivers/gpio/gpio-palmas.c

>  #ifdef CONFIG_OF_GPIO
> -     palmas_gpio->gpio_chip.of_node = palmas->dev->of_node;
> +     palmas_gpio->gpio_chip.of_node = pdev->dev.of_node;
>  #endif

That still scares me slightly, in case someone is already using this
driver and this changes how it works, and it breaks something, but I
don't think anyone is, so this should be OK too.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to