On Mon 22-07-13 17:36:23, Joonsoo Kim wrote: > This label is not needed now, because there is no error handling > except returing NULL. > > Signed-off-by: Joonsoo Kim <iamjoonsoo....@lge.com> > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index fc4988c..d87f70b 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -546,11 +546,11 @@ static struct page *dequeue_huge_page_vma(struct hstate > *h, > */ > if (!vma_has_reserves(vma) && > h->free_huge_pages - h->resv_huge_pages == 0) > - goto err; > + return NULL; > > /* If reserves cannot be used, ensure enough pages are in the pool */ > if (avoid_reserve && h->free_huge_pages - h->resv_huge_pages == 0) > - goto err; > + return NULL; > > retry_cpuset: > cpuset_mems_cookie = get_mems_allowed(); > @@ -573,9 +573,6 @@ retry_cpuset: > if (unlikely(!put_mems_allowed(cpuset_mems_cookie) && !page)) > goto retry_cpuset; > return page; > - > -err: > - return NULL;
This doesn't give us anything IMO. It is a matter of taste but if there is no cleanup I would prefer no err label. -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
