(2013/07/16 3:20), Oleg Nesterov wrote: > On 07/09, Masami Hiramatsu wrote: >> >> Wait for disabling all running kprobe handlers when a kprobe >> event is disabled, since the caller, trace_remove_event_call() >> supposes that a removing event is disabled completely by >> disabling the event. >> With this change, ftrace can ensure that there is no running >> event handlers after disabling it. >> >> Changes in V2: >> - Comment (in code) for clarify why we need to wait there. >> >> Signed-off-by: Masami Hiramatsu <[email protected]> > > Agreed. > > We need this change in any case, whatever we do in trace/trace_events.c > and in unregister_trace_probe().
Steven, I think this patch is still needed anyway even if we are discussing file handling bugs, because this fixes another timing bug. Thank you, -- Masami HIRAMATSU IT Management Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: [email protected] -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
