Chen Gang F T <chen.gang.flying.transfor...@gmail.com> writes: > On 07/09/2013 04:07 PM, Rusty Russell wrote: >> Chen Gang <gang.c...@asianux.com> writes: >>> When sysfs_create_file() fails, recommend to print the related failure >>> information. And it is useless to still 'KOBJ_ADD' to user space. >>> >>> Signed-off-by: Chen Gang <gang.c...@asianux.com> >> >> sysfs_create_file() should not fail during boot, should it? >> > > Hmm..., please reference locate_module_kobject() in "kernel/params.c", > which is an '__init' function, and also call sysfs_create_file(), it > processes the related error. > > So I recommend to get the check too in version_sysfs_builtin().
It still can't fail. sysfs_create_file() can fail due to OOM (not at boot) or name duplication (not here). You can BUG_ON() if you want. And feel free to fix locate_module_kobject() in a separate patch. Cheers, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
