On 02/07/13 07:16, Srivatsa S. Bhat wrote: > On 07/01/2013 09:34 PM, James Hogan wrote: >> The route_irq() function needs to preserve the irq mask by using the >> _irqsave/irqrestore variants of raw spin lock functions instead of the >> _irq variants. This is because it is called from __cpu_disable() (via >> migrate_irqs()), which is called with IRQs disabled, so using the _irq >> variants re-enables IRQs. >> >> This appears to have been causing occasional hits of the >> BUG_ON(!irqs_disabled()) in __irq_work_run() during CPU hotplug soak >> testing: >> BUG: failure at kernel/irq_work.c:122/__irq_work_run()! >> >> Signed-off-by: James Hogan <james.ho...@imgtec.com> >> --- > > Reviewed-by: Srivatsa S. Bhat <srivatsa.b...@linux.vnet.ibm.com>
Thanks for taking the time to review these patches Cheers James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
