On 06/10/2013 06:23 PM, vcap...@gnugeneration.com wrote:
+ if (!uid_eq(cred->euid, tcred->suid) &&
+ !uid_eq(cred->euid, tcred->uid) &&
+ !uid_eq(cred->uid, tcred->suid) &&
+ !uid_eq(cred->uid, tcred->uid) &&
+ !ns_capable(cred->user_ns, CAP_KILL)) {
+ ret = -EPERM;
+ goto out_unlock;
+ }
+
That check's far too permissive.
This sounds like it will break anything that uses wait and expects its
children to not be stolen out from under it.
Also, you'll have problems with screen -x or the default tmux shareable
configuration. It sounds like this is better done in userspace.
--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
