Hi Ben, On Fri, Jun 07, 2013 at 04:48:58AM +0100, Ben Hutchings wrote: > > From: Sean Connor <sconnor...@allyinics.org> > > > > commit 69a4cfdd444d1fe5c24d29b3a063964ac165d2cd upstream. > > > > Set card->private_data in snd_ice1712_create for fixing NULL > > dereference in snd_ice1712_remove(). > > This bug appears to have been introduced in Linux 3.8 and doesn't need > fixing in 2.6.32.
Ah indeed that's true. Does it harm to have it or not ? because I'm still seeing a number of places where we have this in the driver : struct snd_ice1712 *ice = ac97->private_data; I'd like to be sure that no other function risks to dereference the same pointer. Also, I'm noting that 3.0/3.4 have this fix, while 3.2 does not. So I'm hesitant what to do with this patch. Thanks, Willy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
