On Fri, May 31, 2013 at 12:13 PM, Hebbar Gururaja
<gururaja.heb...@ti.com> wrote:
> struct gpio_leds_priv {
> int num_leds;
> + /* Two optional pin states - default & sleep */
> + struct pinctrl *pinctrl;
> + struct pinctrl_state *pins_default;
> + struct pinctrl_state *pins_sleep;
> struct gpio_led_data leds[];
> };
Or actually, wait. You're adding quite a lot of these.
Could you try:
- Adding pins_sleep and pins_idle to struct dev_pin_info
in include/linux/pinctrl/devinfo.h
- Modify drivers/base/pinctrl.c to optionally look up
sleep and idle states, you can make that code
#ifdef CONFIG_PM I think.
- Add something like static inline functions to
include/linux/pinctrl/consumer.h
with names like pinctrl_select_pm_idle(struct device *)
pinctrl_select_pm_sleep(struct device *) to switch states
using the device core containers, and includes
checking IS_ERR() on the handles etc.
I think this will save a *lot* of identical code in all the
drivers, that will just have to call
pinctrl_select_pm_sleep(), pinctrl_select_pm_default()
pinctrl_select_pm_idle() instead of all the complex code.
This is what I planned to do but never got around to.
Please?
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
