On 05/30/2013 11:35 PM, Kyle McMartin wrote:
> On Thu, May 30, 2013 at 09:18:43AM +0800, Chen Gang wrote:
>> > 
>> > 'boot_args' is an input args, and 'boot_command_line' has a fix length.
>> > 
>> > So need use strlcpy() instead of strcpy() to avoid memory overflow.
>> > 
> This is basically impossible, since boot_args is fixed in size by palo,
> initialized to zero, and length checked in the bootloader. It's also
> only 256+4 bytes compared to the 1024 bytes set aside for
> boot_command_line.
> 
> That said, it's harmless to use strlcpy here, and obviously (more)
> correct. Thanks!
> 

OK, thanks.

> Acked-by: Kyle McMartin <k...@mcmartin.ca>
> 
> 

Thank you. :-)


-- 
Chen Gang

Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to