On 2013/5/22 12:49, Libo Chen wrote: > > ping... > > On 2013/5/5 16:38, chenlib...@gmail.com wrote: >> From: Libo Chen <libo.c...@huawei.com> >> >> There is no need to free bcom_eng if kzalloc fail >>
kfree(NULL) is fine. We gain nothing from this patch, and it even adds one more line to the code, so just drop thi patch. >> Signed-off-by: Libo Chen <libo.c...@huawei.com> >> --- >> drivers/dma/bestcomm/bestcomm.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/dma/bestcomm/bestcomm.c >> b/drivers/dma/bestcomm/bestcomm.c >> index a8c2e29..300ee2d 100644 >> --- a/drivers/dma/bestcomm/bestcomm.c >> +++ b/drivers/dma/bestcomm/bestcomm.c >> @@ -400,7 +400,7 @@ static int mpc52xx_bcom_probe(struct platform_device *op) >> printk(KERN_ERR DRIVER_NAME ": " >> "Can't allocate state structure\n"); >> rv = -ENOMEM; >> - goto error_sramclean; >> + goto error_kzalloc; >> } >> >> /* Save the node */ >> @@ -449,6 +449,7 @@ error_release: >> release_mem_region(res_bcom.start, sizeof(struct mpc52xx_sdma)); >> error_sramclean: >> kfree(bcom_eng); >> +error_kzalloc: >> bcom_sram_cleanup(); >> error_ofput: >> of_node_put(op->dev.of_node); >> > > > . > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
