> -----Original Message----- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Thursday, May 16, 2013 12:02 AM > To: KY Srinivasan > Cc: linux-kernel@vger.kernel.org; de...@linuxdriverproject.org; > oher...@suse.com; jbottom...@parallels.com; h...@infradead.org; linux- > s...@vger.kernel.org; a...@canonical.com; jasow...@redhat.com > Subject: Re: [PATCH 1/6] Drivers: hv: vmbus: Implement multi-channel support > > On Wed, May 15, 2013 at 03:02:29PM -0700, K. Y. Srinivasan wrote: > > +/* > > + * Retrieve the (sub) channel on which to send an outgoing request. > > + * When a primary channel has multiple sub-channels, we choose a > > + * channel whose VCPU binding is closest to the VCPU on which > > + * this call is being made. > > + */ > > +struct vmbus_channel *get_outgoing_channel(struct vmbus_channel > *primary) > > That's a _very_ vague global symbol name you are adding to the kernel. > Same goes for the other functions you are adding here, please fix that, > and make them have the vmbus_ prefix, like everything else in this > patch.
Will do. K. Y -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
