On Tuesday 23 April 2013 21:41:03 Arnd Bergmann wrote: > On Tuesday 23 April 2013, Marc Dietrich wrote: > > On Tuesday 23 April 2013 18:30:46 Arnd Bergmann wrote: > > > The serio code can be a loadable module, which in turn means that nvec > > > also has to be a module, so mark it as "tristate" in Kconfig. > > > > oh, I didn't saw this randconfig error posting. NVEC isn't prepared for > > modularized builds yet (it's on the TODO list though). So better say > > SERIO=y here. Looking a bit closer, there is other stuff which can also > > be a module (GPIOLIB, I2C, ...) so these also need a =y. > > What is the problem with building it as a module? It looks all fine in that > regard.
It builds, but I haven't tried out it yet. At least the mfd children need to unregister the event notifier I guess. Anyway, I have no time to test this now, so I prefer to force =y for the dependencies for now. > I also did not see any problems with the other symbols, but that may be > because they get turned on as built-in even in allmodconfig. Marking it > as tristate certainly avoids the problem altogether. > > > Should a post a patch? > > If you have follow-on patches, they need to go on top now, since Greg > already took this patch. arrr, I wonder why Greg thought that a 4 minute review time is enough :-( I'll try to post a patch tomorrow then. Marc -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
