Arnd, On Tuesday 23 April 2013 18:30:46 Arnd Bergmann wrote: > The serio code can be a loadable module, which in turn means that nvec > also has to be a module, so mark it as "tristate" in Kconfig.
oh, I didn't saw this randconfig error posting. NVEC isn't prepared for modularized builds yet (it's on the TODO list though). So better say SERIO=y here. Looking a bit closer, there is other stuff which can also be a module (GPIOLIB, I2C, ...) so these also need a =y. Should a post a patch? Marc > drivers/built-in.o: In function `nvec_mouse_remove': > drivers/staging/nvec/nvec_ps2.c:136: undefined reference to > `serio_unregister_port' drivers/built-in.o: In function `nvec_mouse_probe': > drivers/staging/nvec/nvec_ps2.c:126: undefined reference to > `__serio_register_port' drivers/built-in.o: In function > `nvec_ps2_notifier': > drivers/staging/nvec/nvec_ps2.c:84: undefined reference to `serio_interrupt' > drivers/staging/nvec/nvec_ps2.c:91: undefined reference to > `serio_interrupt' > > Signed-off-by: Arnd Bergmann <a...@arndb.de> > Cc: Marc Dietrich <marvi...@gmx.de> > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > --- > drivers/staging/nvec/Kconfig | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/nvec/Kconfig b/drivers/staging/nvec/Kconfig > index f779fdc..7e61ada 100644 > --- a/drivers/staging/nvec/Kconfig > +++ b/drivers/staging/nvec/Kconfig > @@ -1,5 +1,5 @@ > config MFD_NVEC > - bool "NV Tegra Embedded Controller SMBus Interface" > + tristate "NV Tegra Embedded Controller SMBus Interface" > depends on I2C && GPIOLIB && ARCH_TEGRA > select MFD_CORE > help > @@ -7,28 +7,28 @@ config MFD_NVEC > controller. > > config KEYBOARD_NVEC > - bool "Keyboard on nVidia compliant EC" > + tristate "Keyboard on nVidia compliant EC" > depends on MFD_NVEC && INPUT > help > Say Y here to enable support for a keyboard connected to > a nVidia compliant embedded controller. > > config SERIO_NVEC_PS2 > - bool "PS2 on nVidia EC" > + tristate "PS2 on nVidia EC" > depends on MFD_NVEC && SERIO > help > Say Y here to enable support for a Touchpad / Mouse connected > to a nVidia compliant embedded controller. > > config NVEC_POWER > - bool "NVEC charger and battery" > + tristate "NVEC charger and battery" > depends on MFD_NVEC && POWER_SUPPLY > help > Say Y to enable support for battery and charger interface for > nVidia compliant embedded controllers. > > config NVEC_PAZ00 > - bool "Support for OEM specific functions on Compal PAZ00 based devices" > + tristate "Support for OEM specific functions on Compal PAZ00 based > devices" depends on MFD_NVEC && LEDS_CLASS > help > Say Y to enable control of the yellow side leds on Compal PAZ00 based -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
