From: Andi Kleen <a...@linux.intel.com>
Check for const __devinitdata and non const __devinitconst
People get this regularly wrong and it breaks the LTO builds,
as it causes a section attribute conflict.
This doesn't catch all mistakes -- spreading over multiple lines,
getting const pointers wrong, but hopefully the common ones.
Signed-off-by: Andi Kleen <a...@linux.intel.com>
---
scripts/checkpatch.pl | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 4de4bc4..579f92d 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2466,6 +2466,15 @@ sub process {
"missing space after $1 definition\n" . $herecurr);
}
+# check for __devinitdata with const or const without __devintconst
+# XXX should scan multiple lines and handle misplaced consts for pointers
+ if ($line =~ /const/ && $line =~ /__(dev)?initdata/) {
+ ERROR("DEVINITCONST", "const init definition must use
__devinitconst");
+ }
+ if ($line =~ /__(dev)?initconst/ && $line !~ /\Wconst\W/) {
+ ERROR("DEVINITCONST", "__devinitconst must have have const
definition");
+ }
+
# check for spacing round square brackets; allowed:
# 1. with a type on the left -- int [] a;
# 2. at the beginning of a line for slice initialisers -- [0...10] = 5,
--
1.7.7.6
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
